Add geosearch autocomplete. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
changed the title
toolness
commented
Sep 23, 2018
| @@ -59,7 +64,7 @@ export default class ReactTestingLibraryPal { | |||
| const input = this.rr.getByLabelText(matcher, { | |||
| selector: 'input, select' | |||
| }) as HTMLInputElement; | |||
| input.value = value; | |||
| rt.fireEvent.change(input, { target: { value } }); | |||
There was a problem hiding this comment.
This is important because it causes the onChange handlers of the input fields to be called, if they are set, which is particularly important for the autocomplete widget. I actually had to get assistance from the Downshift community to figure this out and they were very quick to help out.
toolness
commented
Sep 23, 2018
| @@ -230,6 +230,11 @@ | |||
| MIDDLEWARE.append( | |||
| 'rollbar.contrib.django.middleware.RollbarNotifierMiddlewareExcluding404') | |||
|
|
|||
| CSP_CONNECT_SRC = [ | |||
| "'self'", | |||
| "https://geosearch.planninglabs.nyc" | |||
There was a problem hiding this comment.
Hmm, this could get out-of-sync with the actual web service we use to perform the geo search but um, at least the progressive enhancement error boundary will kick in and it will downgrade to baseline. Also, it is extremely unlikely to happen.
This was referenced Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This progressively enhances onboarding step 1 to use the NYC Planning Labs autocomplete API, powered by the excellent Downshift React component.
If any network or runtime errors occur in the component, the app will fall back to the baseline experience (the separate address and borough fields) using a new
<ProgressiveEnhancement>component that this PR introduces.To do
The user shouldn't actually be able to submit the form until they've selected a valid address that has the street and borough information.We can punt on this, now that the field shows server errors and only displays a non-empty value if it's a valid one.If the server says that either the address or borough field has errors, which would be very unusual, we should probably downgrade to the baseline experience just to be safe.We deal with the "this field is required" case now, which is going to be the vast majority of use cases, so I'm not going to worry about the extremely unlikely edge case where the server thinks the address is invalid.